Glenn Randers-Pehrson
2017-04-20 23:53:51 UTC
Hi, would one of our CMAKE experts have a look at this?
Glenn
---------- Forwarded message ----------
From: Robert Dailey <***@github.com>
Date: Thu, Apr 20, 2017 at 4:14 PM
Subject: [glennrp/libpng] Get CMake builds for Android NDK working (#162)
To: glennrp/libpng <***@noreply.github.com>
Cc: Subscribed <***@noreply.github.com>
- Use CMAKE_HOST_WIN32 appropriately (for cross compiling)
- Disable procedurally generated code steps for Android (They don't work)
Note: I am sure that you do not want to merge this, especially since I
basically hacked some of these changes just to get libpng building for
Android NDK. But could you offer some pointers to how to make these changes
permanent for upstream consumption? Why do the code generations steps not
work for Android? Is disabling the generation custom targets appropriate
for Android?
------------------------------
You can view, comment on, or merge this pull request online at:
https://github.com/glennrp/libpng/pull/162
Glenn
---------- Forwarded message ----------
From: Robert Dailey <***@github.com>
Date: Thu, Apr 20, 2017 at 4:14 PM
Subject: [glennrp/libpng] Get CMake builds for Android NDK working (#162)
To: glennrp/libpng <***@noreply.github.com>
Cc: Subscribed <***@noreply.github.com>
- Use CMAKE_HOST_WIN32 appropriately (for cross compiling)
- Disable procedurally generated code steps for Android (They don't work)
Note: I am sure that you do not want to merge this, especially since I
basically hacked some of these changes just to get libpng building for
Android NDK. But could you offer some pointers to how to make these changes
permanent for upstream consumption? Why do the code generations steps not
work for Android? Is disabling the generation custom targets appropriate
for Android?
------------------------------
You can view, comment on, or merge this pull request online at:
https://github.com/glennrp/libpng/pull/162